Skip to content

[Term Entry] C# Math-functions: BigMul() #7964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2025
Merged

[Term Entry] C# Math-functions: BigMul() #7964

merged 3 commits into from
Nov 19, 2025

Conversation

@ksuraev
Copy link
Contributor

@ksuraev ksuraev commented Nov 7, 2025

Description

This PR adds a new documentation entry for the C# BigMul() method in maths-functions.
The new file is located at content/c-sharp/concepts/math-functions/terms/bigmul/bigmul.md

Issue Solved

Closes #7947

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Nov 8, 2025
mamtawardhani
mamtawardhani approved these changes Nov 8, 2025
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a second review! 🚀

@ksuraev
Copy link
Contributor Author

ksuraev commented Nov 8, 2025

Looks good for a second review! 🚀

Thank you for the feedback/review! Just two things to note (which I did not make clear either in my commit) -

  1. yes Int128/UInt128 were introduced in .NET 7, however, the overloads BigMul(Int64, Int64) and BigMul(UInt64, UInt64) were introduced in .NET 9 which I did not initially phrase well (apologies).
  2. The three parameter overloads return the high 64-bits and store the low 64-bits in the out parameter. E.g. public static long BigMul(long a, long b, out long low); from .NET docs
    Not sure if you/a maintainer would prefer to make these changes or me :)

@dakshdeepHERE dakshdeepHERE added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Nov 16, 2025
@dakshdeepHERE dakshdeepHERE self-assigned this Nov 16, 2025
dakshdeepHERE
dakshdeepHERE approved these changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dakshdeepHERE dakshdeepHERE added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Nov 19, 2025
@dakshdeepHERE dakshdeepHERE merged commit 9f01639 into Codecademy:main Nov 19, 2025
7 checks passed
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

👋 @ksuraev
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/c-sharp/math-functions/bigmul

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@ksuraev ksuraev deleted the csharp-math-bigmul branch November 19, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mamtawardhani mamtawardhani mamtawardhani approved these changes

@dakshdeepHERE dakshdeepHERE dakshdeepHERE approved these changes

Assignees

@mamtawardhani mamtawardhani

@dakshdeepHERE dakshdeepHERE

Labels

c# C# entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Term Entry] C# Math-functions: BigMul()

4 participants

@ksuraev @CLAassistant @mamtawardhani @dakshdeepHERE